Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search: Fix creating new item wit disabled menu #216

Merged
merged 1 commit into from
May 27, 2024

Conversation

evgenoid
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

On adding new item that matched with existed in the list with disabled menu - both removing

What is the new behavior?

On adding new item that matched with existed in the list with disabled menu - just clear input

Does this PR introduce a breaking change?

[ ] Yes
[x] No
Screen.Recording.2024-05-27.at.13.21.40.mov

Copy link

netlify bot commented May 27, 2024

Deploy Preview for reablocks-storybook ready!

Name Link
🔨 Latest commit 2056454
🔍 Latest deploy log https://app.netlify.com/sites/reablocks-storybook/deploys/665460c1afbd2100087b1769
😎 Deploy Preview https://deploy-preview-216--reablocks-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@evgenoid evgenoid changed the title Search: Fix crating new item wit disabled menu Search: Fix creating new item wit disabled menu May 27, 2024
@evgenoid evgenoid merged commit a4f0c3d into master May 27, 2024
5 checks passed
@evgenoid evgenoid deleted the search/fix_items_creating branch May 27, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants