Open
Conversation
Contributor
|
A general question about such language extensions is whether they should be part of the core language syntax or ppx syntax extensions. Is there something in the proposed extension that would make it tedious to describe them as a ppx extension. Wondering if you had any thoughts on this? |
Contributor
Author
|
@kayceesrk I share your concerns, and I'm not sure if this is the right idea. So far I'm leaning more towards staying close to the actual GraphQL query syntax (but still giving us the freedom to improve where possible). PPX is definitely an interesting option though: Although I'm not sure how we would add support for fragments here. |
Contributor
|
@SanderSpies this is something that I mentioned here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WORK IN PROGRESS.
This is just syntax for now - it doesn't work or anything.
I would love to get feedback on this already before I continue with implementing the other details.