-
Notifications
You must be signed in to change notification settings - Fork 73
feat: add bindings for HTMLFormControlsCollection, HTMLOptionsCollection, RadioNodeList, etc #195
base: master
Are you sure you want to change the base?
Conversation
5a2beff
to
7f2387a
Compare
Thanks, I'll try to review soon. Just a note, that after the rescript-compiler PR merge, it will be published in BS 8.something). The problem is, that would require bs-webapi to upgrade to 8.something to be able to use the new types introduced there. And BS 8+ has some backward-incompatible changes, which means upgrading to that version would prevent some folks from being able to upgrade bs-webapi. In the interim, I would recommend to introduce the types independently here and then later we can decide to alias them to the BS types for backward-compatibility. |
Yeah I was thinking of that as well, just have the version to get it linked against my local rescript version for now. |
Needs to wait for rescript-lang/rescript#4622 at the moment, so the 0.20 version is just placeholderNot really sure how to proceed with the
namedItem
binding, when I tried to putisRadioNodeList
into theWebapi__Dom__RadioNodeList
module, it gave me an error that the'a
couldn't be generalized or something like that.TODO: