Skip to content
This repository has been archived by the owner on Nov 1, 2021. It is now read-only.

feat: add bindings for HTMLFormControlsCollection, HTMLOptionsCollection, RadioNodeList, etc #195

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

illusionalsagacity
Copy link
Contributor

@illusionalsagacity illusionalsagacity commented Aug 18, 2020

Needs to wait for rescript-lang/rescript#4622 at the moment, so the 0.20 version is just placeholder

Not really sure how to proceed with the namedItem binding, when I tried to put isRadioNodeList into the Webapi__Dom__RadioNodeList module, it gave me an error that the 'a couldn't be generalized or something like that.

TODO:

  • write some smoke tests
  • undo ResizeObserver / ResizeObserverEntry t change for compat

@illusionalsagacity illusionalsagacity force-pushed the html-form-controls-collection branch from 5a2beff to 7f2387a Compare August 18, 2020 01:46
@yawaramin
Copy link
Collaborator

Thanks, I'll try to review soon. Just a note, that after the rescript-compiler PR merge, it will be published in BS 8.something). The problem is, that would require bs-webapi to upgrade to 8.something to be able to use the new types introduced there. And BS 8+ has some backward-incompatible changes, which means upgrading to that version would prevent some folks from being able to upgrade bs-webapi. In the interim, I would recommend to introduce the types independently here and then later we can decide to alias them to the BS types for backward-compatibility.

@illusionalsagacity
Copy link
Contributor Author

Thanks, I'll try to review soon. Just a note, that after the rescript-compiler PR merge, it will be published in BS 8.something). The problem is, that would require bs-webapi to upgrade to 8.something to be able to use the new types introduced there. And BS 8+ has some backward-incompatible changes, which means upgrading to that version would prevent some folks from being able to upgrade bs-webapi. In the interim, I would recommend to introduce the types independently here and then later we can decide to alias them to the BS types for backward-compatibility.

Yeah I was thinking of that as well, just have the version to get it linked against my local rescript version for now.

@illusionalsagacity illusionalsagacity marked this pull request as ready for review August 20, 2020 04:03
@illusionalsagacity illusionalsagacity changed the title feat: add bindings for HTMLFormControlsCollection, RadioNodeList, etc feat: add bindings for HTMLFormControlsCollection, HTMLOptionsCollection, RadioNodeList, etc Aug 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants