This repository has been archived by the owner on Nov 1, 2021. It is now read-only.
Rename Dom.Image to Dom.ImageData, add implementation for Dom.Image #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glennsl
suggested changes
Feb 15, 2020
There was a problem hiding this comment.
Thanks for this. Image should definitely be renamed to ImageData. I also think it should be moved to Webapi.Canvas. But (the actual) Image already exists as HtmlImageElement. Perhaps it would be a good idea to have an Image module that proxies just the make function though, and otherwise points to HtmlImageElement for the rest of the API. But there's no need to reimplement it at least.
|
Oh, I didn't realize there is a |
|
Will create a new PR from another branch. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves issue: #168
There is a backwards compatibility break in naming of the files.