Fix and deprecate the "Main (alt recording)" section in the Cycle Action editor #1902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4a37570 fixed running main actions from alt sections but broke alt-recording cycle actions until c9dade5. Actions added to an alt section are effectively added to all of them + Main. However running those from another section than one it was originally registered in has never worked. This commit disables the creation of new cycle actions in the "Main (alt recording)" section. Old actions are not migrated to the Main section to preserve the existing command ID and shortcuts. Also, only for users who do not already have cycle actions in that section, it makes the alt-recording section an alias of the Main section when selected in the editor's combo box. (Hiding it would be better, however that would require a bigger rework.)
cfillion
changed the title
|
✅ Build sws 1132-master completed (commit 881059e590 by @cfillion) Windows 64-bitWindows 32-bitmacOS x86 64-bitmacOS x86 32-bitmacOS ARM 64-bitLinux x86 64-bitLinux ARM 64-bit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4a37570 fixed running main actions from alt sections but broke alt-recording cycle actions until c9dade5.
Actions added to an alt section are effectively added to all of them + Main. However running those from another section than in the one it was originally registered in has never worked.
This commit disables the creation of new cycle actions in the "Main (alt recording)" section.
Old actions are not migrated to the Main section to preserve the existing command ID and shortcuts.
Also, only for users who do not already have cycle actions in that section, it makes the alt-recording section an alias of the Main section when selected in the editor's combo box. (Hiding it would be better, however that would require a bigger rework.)