Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload progress notifications should not be reported after client reset if no local changes to upload #7970

Open
sync-by-unito bot opened this issue Aug 8, 2024 · 1 comment
Assignees

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented Aug 8, 2024

After a discard local client reset or a client reset with recovery and there are no pending local changes to be uploaded, PBS sync sessions are reporting an upload progress notificiation of [uploadable: 0, uploaded: 0, estimate: 1.0] and non-streaming upload progress callbacks are being expired.

While this notification is being generated by an empty DOWNLOAD message that is received from the server immediately following the client reset diff, this operation is incorrect and no progress notification should be sent at all and non-streaming upload progress callbacks should not be expired.

Copy link
Author

sync-by-unito bot commented Aug 8, 2024

➤ PM Bot commented:

Jira ticket: RCORE-2235

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant