Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RCORE-2235 Upload progress notifications should not be reported after client reset if no local changes to upload #7971

Closed
wants to merge 4 commits into from

Conversation

michael-wb
Copy link
Contributor

@michael-wb michael-wb commented Aug 8, 2024

What, How & Why?

If an empty progress [uploadable: 0, uploaded: 0] or [downloadable: 0, downloaded: 0] is received by the SyncProgressNotifier::update() function then a progress notification will not be generated for that direction.

This also addresses the issue where an upload progress notification is reported after a client reset with recovery that did not generate any pending local changes or a discard local client reset.

Fixes #7970

☑️ ToDos

  • 📝 Changelog update
  • 🚦 Tests (or not relevant)
  • [ ] C-API, if public C++ API changed
  • [ ] bindgen/spec.yml, if public C++ API changed

@michael-wb michael-wb self-assigned this Aug 8, 2024
@cla-bot cla-bot bot added the cla: yes label Aug 8, 2024
Copy link

coveralls-official bot commented Aug 8, 2024

Pull Request Test Coverage Report for Build michael.wilkersonbarker_1325

Details

  • 39 of 39 (100.0%) changed or added relevant lines in 2 files are covered.
  • 75 unchanged lines in 8 files lost coverage.
  • Overall coverage decreased (-0.006%) to 91.101%

Files with Coverage Reduction New Missed Lines %
src/realm/array_string.cpp 1 88.03%
test/fuzz_tester.hpp 1 57.73%
test/test_index_string.cpp 1 93.48%
src/realm/sync/noinst/server/server.cpp 3 74.32%
src/realm/unicode.cpp 3 83.83%
src/realm/table.cpp 4 90.29%
src/realm/sync/network/network.hpp 7 85.28%
test/fuzz_group.cpp 55 42.26%
Totals Coverage Status
Change from base Build 2561: -0.006%
Covered Lines: 217388
Relevant Lines: 238622

💛 - Coveralls

@michael-wb michael-wb marked this pull request as draft August 26, 2024 13:01
@jbreams jbreams closed this Sep 18, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upload progress notifications should not be reported after client reset if no local changes to upload
2 participants