Only allow UnsafeHtml values for :dangerouslySetInnerHTML #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deraen
force-pushed
the
unsafe-html
branch
3 times, most recently
from
03c9357 to
7787b70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/reagent-project/reagent/blob/master/doc/Security.md
This does prevent ONE case where EDN/Transit could be used to create arbitrary HTML elements without going through React.
The
convert-propsis on a very often called code-path, but I hope one JS property check is not too bad. The Clojure map to JS object conversion is already quite slow.