Builds: add data_hash field and update get_or_create method
#12704
+62
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I hit a limitation in PostgreSQL with the length of indexed fields. ``` OperationalError: index row size 6104 exceeds btree version 4 maximum 2704 for index "builds_buildconfig_data_key" DETAIL: Index row references tuple (4760,2) in relation "builds_buildconfig". HINT: Values larger than 1/3 of a buffer page cannot be indexed. Consider a function index of an MD5 hash of the value, or use full text indexing. ``` I found others users hitting the same issue and I ended up with this mixed solution between what AI suggested me and what I found online. I'm not 100% happy with it, but I don't have a better idea right now.
Member
Author
|
A different approach to a solution would be to just handle this exception at https://github.com/readthedocs/readthedocs.org/blob/main/readthedocs/builds/models.py#L878 and skip saving the config into the database for this cases. It doesn't seem to be common. I only found ~10 cases in 3.5M |
Member
|
This was one of my worries about this new method. I'm +1 on using a hash, that should reduce the size of the index as well. |
humitos
commented
Jan 22, 2026
Comment on lines
+16
to
+20
| migrations.AddField( | ||
| model_name="buildconfig", | ||
| name="data_hash", | ||
| field=models.CharField(editable=False, max_length=64, null=True, unique=True), | ||
| ), |
Member
Author
There was a problem hiding this comment.
We need to create a data migration for all these objects to calculate this hash and save it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hit a limitation in PostgreSQL with the length of indexed fields.
I found others users hitting the same issue and I ended up with this mixed solution between what AI suggested me and what I found online.
I'm not 100% happy with it, but I don't have a better idea right now.