Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hosting: Don't check for superprojects on subprojects #11683

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Hosting: Don't check for superprojects on subprojects #11683

wants to merge 2 commits into from

Conversation

ericholscher
Copy link
Member

No description provided.

@ericholscher ericholscher requested a review from a team as a code owner October 15, 2024 14:27
@ericholscher ericholscher mentioned this pull request Oct 15, 2024
Merged
stsewd
stsewd approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@stsewd stsewd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests will probably (or hopefully) need to be updated since this will reduce the number of queries.

@ericholscher
Copy link
Member Author

ericholscher commented Oct 15, 2024 •
edited
Loading

I ran the tests and they were fine? Though we definitely have tests for subprojects.

readthedocs.org/readthedocs/proxito/tests/test_hosting.py

Line 782 in ee2a5d9

def test_number_of_queries_url_subproject(self):

@ericholscher
Copy link
Member Author

AH, I think that test is a subproject, so it will do all the queries still, but the parent project would save queries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stsewd stsewd stsewd approved these changes

Assignees

@ericholscher ericholscher

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericholscher @stsewd