Skip to content

Add Pull Request builds page to settings #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericholscher merged 9 commits into from
Jul 1, 2024
Merged

Add Pull Request builds page to settings #206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
421f944
Add Pull Request builds page to settings
ericholscher Aug 22, 2023
0d4678f
Apply suggestions from code review
ericholscher Aug 23, 2023
eac3578
Rename file
agjohnson Sep 5, 2023
09524ee
Oops, remove old file too.
agjohnson Sep 5, 2023
5f2a610
Merge branch 'main' of github.com:readthedocs/ext-theme into pull-req…
ericholscher Feb 9, 2024
a633ca4
Merge branch 'main' of github.com:readthedocs/ext-theme into pull-req…
ericholscher Jun 25, 2024
a7989bc
Apply suggestions from code review
ericholscher Jun 25, 2024
98a97b3
Fix indent
ericholscher Jun 25, 2024
dceca5b
Don't disable form since it breaks the link to integrations
ericholscher Jun 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions readthedocsext/theme/templates/projects/edit_base.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@
<a class="item {% block project_domains_active %}{% endblock %}" href="{% url "projects_domains" project.slug %}">
{% trans "Domains" %}
</a>
<a class="item {% block project_pull_requests_active %}{% endblock %}" href="{% url "projects_pull_requests" project.slug %}">
{% trans "Pull request builds" %}
</a>
{% if not USE_ORGANIZATIONS %}
<a class="item {% block project_users_active %}{% endblock %}" href="{% url "projects_users" project.slug %}">
{% trans "Maintainers" %}
Expand Down
31 changes: 31 additions & 0 deletions readthedocsext/theme/templates/projects/pull_requests_form.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
{% extends "projects/project_edit_base.html" %}

{% load i18n %}
{% load static %}
{% load crispy_forms_filters %}

{% block title %}{% trans "Pull request builds" %}{% endblock %}

{% block project_pull_requests_active %}active{% endblock %}
{% block project_edit_content_header %}{% trans "Pull request builds" %}{% endblock %}

{% block project_edit_content %}
<p>
{% blocktrans trimmed %}
Enable builds for your pull requests and easily preview changes to your documentation.
{% endblocktrans %}
</p>

<form class="ui form" method="post" action=".">
{% csrf_token %}
{{ form | crispy }}

<input class="ui {% if form.errors and form.is_disabled %}disabled{% endif %} primary button" type="submit"
Copy link
Contributor

@agjohnson agjohnson Jun 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works okay for now, I've noted to undo this pattern with readthedocs/readthedocs.org#11270

value="{% trans " Update" %}">
</form>
{% endblock %}

{% block project_edit_sidebar_help_topics %}
{% include "includes/elements/link.html" with url="https://docs.readthedocs.io/en/stable/pull-requests.html" text="Pull
request builds" is_external=True class="item" %}
{% endblock project_edit_sidebar_help_topics %}