Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved PlayHeader(#1562) #1568

Merged
merged 3 commits into from
Nov 4, 2024

Conversation

joshua-jinu
Copy link
Contributor

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

Fixes #1562

  • Added max-width for the description.
  • Implemented collapse button using useState and useContext to display only the relevant information.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Ran the code locally on my system, manual testing. Checked for functionality and responsiveness across different windows and pages. Ran linter to check for any lint issues.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots or example output

image

image

Added collapse button and updated the max-width for the description.
Copy link

netlify bot commented Oct 31, 2024

Deploy Preview for reactplayio ready!

Name Link
🔨 Latest commit d857b6a
🔍 Latest deploy log https://app.netlify.com/sites/reactplayio/deploys/67266833694bee0008ef97b7
😎 Deploy Preview https://deploy-preview-1568--reactplayio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! contributor, thank you for opening a Pull Request 🎉.

@reactplay/maintainers will review your submission soon and give you helpful feedback. If you're interested in continuing your contributions to open source and want to be a part of a welcoming and fantastic community, we invite you to join our ReactPlay Discord Community.
Show your support by starring ⭐ this repository. Thank you and we appreciate your contribution to open source!
Stale Marking : After 30 days of inactivity this issue/PR will be marked as stale issue/PR and it will be closed and locked in 7 days if no further activity occurs.

@priyankarpal
Copy link
Member

@joshua-jinu Can we enhance the button?

Implemented collapse button using useState and useContext to display only the relevant information.

@joshua-jinu
Copy link
Contributor Author

Sure, any suggestions you have in mind?

@joshua-jinu Can we enhance the button?

Implemented collapse button using useState and useContext to display only the relevant information.

@priyankarpal
Copy link
Member

Sure, any suggestions you have in mind?

@joshua-jinu Can we enhance the button?

Implemented collapse button using useState and useContext to display only the relevant information.

I have one idea: a black border without a black background. Let's see if this works; if not, we'll use the first one.

@joshua-jinu
Copy link
Contributor Author

Done @priyankarpal, do check it out and let me know of any required changes

image

Copy link
Member

@priyankarpal priyankarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good 🎉

@priyankarpal priyankarpal merged commit 3a48cc2 into reactplay:main Nov 4, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ [Feature request]: Improve PlayHeader
2 participants