Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/play/zoomlogin refactor1 #1554

Merged
merged 11 commits into from
Oct 17, 2024

Conversation

day-lee
Copy link
Contributor

@day-lee day-lee commented Oct 12, 2024

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

  • Chatbot option buttons have either hover:cursor-pointer or hover:cursor-not-allowed depending on the feature development. "My Account is Locked" is developed but stated as not allowed, hence changed the cursor accordingly.
  • removed unused file
  • refactor label htmlFor to match the input id

Fixes #1555

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

manual test

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots or example output

not-allowed cursor is shown
image
pointer cursor should be displayed
image

Copy link

netlify bot commented Oct 12, 2024

Deploy Preview for reactplayio ready!

Name Link
🔨 Latest commit 37376e6
🔍 Latest deploy log https://app.netlify.com/sites/reactplayio/deploys/670fdfaff3f6740008c2a991
😎 Deploy Preview https://deploy-preview-1554--reactplayio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! contributor, thank you for opening a Pull Request 🎉.

@reactplay/maintainers will review your submission soon and give you helpful feedback. If you're interested in continuing your contributions to open source and want to be a part of a welcoming and fantastic community, we invite you to join our ReactPlay Discord Community.
Show your support by starring ⭐ this repository. Thank you and we appreciate your contribution to open source!
Stale Marking : After 30 days of inactivity this issue/PR will be marked as stale issue/PR and it will be closed and locked in 7 days if no further activity occurs.

Copy link
Member

@priyankarpal priyankarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change class names, use different names, unique class names i.e zoom-login-header so that it doesn't break the CSS of the whole website

src/plays/zoomlogin/components/App.css Outdated Show resolved Hide resolved
src/plays/zoomlogin/components/App.css Outdated Show resolved Hide resolved
src/plays/zoomlogin/components/App.css Outdated Show resolved Hide resolved
src/plays/zoomlogin/components/App.css Outdated Show resolved Hide resolved
tests-examples/demo-todo-app.spec.ts Outdated Show resolved Hide resolved
tests/example.spec.ts Outdated Show resolved Hide resolved
@priyankarpal priyankarpal added the changes required need to change some thing label Oct 14, 2024
* refactor: remove unused files

---------

Co-authored-by: Priyankar Pal <[email protected]>
@priyankarpal priyankarpal added hacktoberfest play request New Play Request. and removed changes required need to change some thing labels Oct 16, 2024
@priyankarpal priyankarpal merged commit dc58208 into reactplay:main Oct 17, 2024
5 of 6 checks passed
@day-lee day-lee removed their assignment Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Refactor] zoomlogin
2 participants