Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created new design events portion #146

Open
wants to merge 26 commits into
base: the-hustle-home-page
Choose a base branch
from
Open

Conversation

debjit
Copy link

@debjit debjit commented Apr 12, 2023

Issue Link:
#144
Note:

  • Font Raleway,Poppins is not added to the tailwind config, please update the tailwind config files to use this fonts.

image

@netlify
Copy link

netlify bot commented Apr 12, 2023

Deploy Preview for activities-reactplay ready!

Name Link
🔨 Latest commit d6991bd
🔍 Latest deploy log https://app.netlify.com/sites/activities-reactplay/deploys/646b3dc7c21a3a0008951337
😎 Deploy Preview https://deploy-preview-146--activities-reactplay.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@debjit debjit requested a review from atapas April 12, 2023 07:47
@debjit debjit self-assigned this Apr 12, 2023
@debjit debjit requested review from joypoddar and removed request for atapas April 12, 2023 09:53
@atapas
Copy link
Member

atapas commented Apr 13, 2023

@debjit where is the issue for this PR?

@debjit
Copy link
Author

debjit commented Apr 13, 2023

Used fonts are not installed and not accacable using tailwind. Needed to update tailwind config file. I removed event component and make it stand alone component.

@debjit debjit requested a review from atapas April 13, 2023 04:32
@atapas
Copy link
Member

atapas commented Apr 13, 2023

Used fonts are not installed and not accacable using tailwind. Needed to update tailwind config file. I removed event component and make it stand alone component.

There must be an issue link to every PR.

@debjit
Copy link
Author

debjit commented Apr 13, 2023

Updated the issue link.

@atapas atapas linked an issue Apr 13, 2023 that may be closed by this pull request
@atapas
Copy link
Member

atapas commented Apr 13, 2023

https://deploy-preview-146--activities-reactplay.netlify.app

Thanks @debjit

Is it still WIP? I do not see the link from home page takes to a events page.

@debjit
Copy link
Author

debjit commented Apr 13, 2023

Every card is a link to its page. The whole card is a button.

@atapas
Copy link
Member

atapas commented Apr 13, 2023

Every card is a link to its page. The whole card is a button.

How about this link?

image

@debjit
Copy link
Author

debjit commented Apr 13, 2023

Please share any landing page for event, I will forward to that, did not found any. So left it blank for later update.
Here is a code that is used to populate this buttons link , but it too does not have the landing page for the event.

          href={
            reactPlayLive
              ? "https://www.youtube.com/playlist?list=PLIJrr73KDmRxqfDS58ZC3MoianOjcm__Y"
              : ""
          }
          target="_blank"
        >```

@atapas
Copy link
Member

atapas commented Apr 13, 2023

Please share any landing page for event, I will forward to that, did not found any. So left it blank for later update. Here is a code that is used to populate this buttons link , but it too does not have the landing page for the event.

          href={
            reactPlayLive
              ? "https://www.youtube.com/playlist?list=PLIJrr73KDmRxqfDS58ZC3MoianOjcm__Y"
              : ""
          }
          target="_blank"
        >```

@debjit the issue is about creating an event page which has all the events listed and link it with the View all link. So you need to create a new event page that runs on the /evets route and link it from the view all link. Is it clear now?

@debjit
Copy link
Author

debjit commented Apr 13, 2023

OK. Is this the /event page mockup?
https://xd.adobe.com/view/9a88daac-8773-4551-a230-9c75a172d560-cfdb/screen/5b56e413-2682-44fb-b648-1858b846d1be/specs/
I was told by @ap221882 to update this section acording to design only.
I can just add /event link but it will show 404 error.
Should I add broken link?

@atapas
Copy link
Member

atapas commented Apr 13, 2023

https://xd.adobe.com/view/9a88daac-8773-4551-a230-9c75a172d560-cfdb/screen/5b56e413-2682-44fb-b648-1858b846d1be/specs/

Nope!

You should add a page for /events that should list all the events. The Home page only shows a latest few 3 or 5. What if we have 50 events. So this /events page will have all those tiles.

Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@debjit These changes are looking good to me.

Pending Tasks:

  • Add a new events page
  • Use the same Events data structure to populate the events page.
  • The new Events page should run on the /events route
  • Make all the events data accurate.

Copy link
Collaborator

@joypoddar joypoddar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/events page's footer is different from the main page footer

Copy link
Collaborator

@joypoddar joypoddar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
The subtitle under the logo has a different font-weight and in the first one, it's repeating. Kindly request @atapas to give you the proper images and specs.

@debjit
Copy link
Author

debjit commented Apr 17, 2023

As you can see and read that I am waiting fot the real information, and the image.

  1. No,1 image has it slogan embaded into page, please visit the demo or check the code,
  2. "/events page's footer is different from the main page footer" We need to refactor the Header and footer. I did not add or removed anything it is what it is. I just created the content inside layout. After refactoring it will be same.

@joypoddar
Copy link
Collaborator

@debjit the font below the logo is still catching my attention. I am guessing you have not been communicated what the exact font is. I did a little digging and found that Bebas Neue could be a fit. I would still request @atapas to look into it.

@joypoddar
Copy link
Collaborator

image
I am unable to see the ReactPlay Live section in the preview.

@atapas kindly check if this is occurring for you too?

components/Footer.js Show resolved Hide resolved
components/event/EventIndexCardWithDetails.js Show resolved Hide resolved
services/metadata/events.js Show resolved Hide resolved
components/event/EventSection.js Show resolved Hide resolved
@debjit debjit dismissed joypoddar’s stale review May 19, 2023 05:12

Redesigning the data fetching. We are now getting all the data from graphql. No local data source is used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a events page and link from the hustles home page
4 participants