-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created new design events portion #146
base: the-hustle-home-page
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for activities-reactplay ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
@debjit where is the issue for this PR? |
Used fonts are not installed and not accacable using tailwind. Needed to update tailwind config file. I removed event component and make it stand alone component. |
There must be an issue link to every PR. |
Updated the issue link. |
Thanks @debjit Is it still WIP? I do not see the link from home page takes to a events page. |
Every card is a link to its page. The whole card is a button. |
Please share any landing page for event, I will forward to that, did not found any. So left it blank for later update.
|
@debjit the issue is about creating an event page which has all the events listed and link it with the View all link. So you need to create a new event page that runs on the /evets route and link it from the view all link. Is it clear now? |
OK. Is this the /event page mockup? |
Nope! You should add a page for /events that should list all the events. The Home page only shows a latest few 3 or 5. What if we have 50 events. So this /events page will have all those tiles. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@debjit These changes are looking good to me.
Pending Tasks:
- Add a new events page
- Use the same Events data structure to populate the events page.
- The new Events page should run on the /events route
- Make all the events data accurate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/events page's footer is different from the main page footer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The subtitle under the logo has a different font-weight and in the first one, it's repeating. Kindly request @atapas to give you the proper images and specs.
As you can see and read that I am waiting fot the real information, and the image.
|
@atapas kindly check if this is occurring for you too? |
Redesigning the data fetching. We are now getting all the data from graphql. No local data source is used.
Issue Link:
#144
Note: