Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to require PHP 7.1+ #316

Merged
merged 3 commits into from
Jun 3, 2024
Merged

Update to require PHP 7.1+ #316

merged 3 commits into from
Jun 3, 2024

Conversation

clue
Copy link
Member

@clue clue commented May 31, 2024

This changeset updates the project to require PHP 7.1+ and drop legacy PHP < 7.1 and HHVM as discussed in #312. I'm marking this as a BC break for anybody still stuck on very old PHP versions, but there's little chance this will affect any current projects otherwise.

This PR aims to contain the minimal changeset to update the PHP version requirement only. Follow-up PRs will update our APIs to leverage newer language features.

Builds on top of #310 and others
Refs reactphp/cache#58

Copy link
Member

@SimonFrings SimonFrings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went over everything, only found one small nit, but the rest looks good :)

tests/SecureServerTest.php Outdated Show resolved Hide resolved
Copy link
Member

@SimonFrings SimonFrings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, let's ship it 🚀

@SimonFrings SimonFrings merged commit 9f04466 into reactphp:3.x Jun 3, 2024
17 checks passed
@SimonFrings SimonFrings deleted the php7.1 branch June 3, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants