Drop deprecated alternative Connector
constructor argument order
#315
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simple changeset drops the deprecated alternative
Connector
constructor argument order. As ofv1.9.0
, we recommend using the newConnector
signature with the optional$context
as first argument and optional$loop
as second argument, so upgrading should be straightforward for most use cases:The original deprecation message has been in place for a couple of years already, so this should be relatively safe to apply.
Note that this temporarily introduces an implicitly nullable type that should be removed in a follow-up as discussed in reactphp/promise#260. Additionally, a follow-up PR should drop the entire
$loop
argument as discussed in #312.Builds on top of #264 and #314.