-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update fileoptimizer.ico #260
Update fileoptimizer.ico #260
Conversation
Reupload file icon, the last is corrupted?
Please reupload this icon file, Rapps show this message in log file to try show fileoptimizer app: fixme:(dll/win32/usp10/opentype.c:1262) TODO: subtype 1 (Simple context glyph substitution) I send the file icon again, greetings to everyone. |
Cannot yet display PNG icons |
Yes @katahiromz, sorry, I send the file in correct format again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only touch it, if you can provide a compatible icon for now. Your current proposal is not.
@JoachimHenze How? I have uploaded the fileoptimizer.ico file to the icons folder again. I have already verified that it is indeed an ico file and not a png file (which was the previous case when the fileoptimizer app was registered in rapps). |
This still looks like a png file renamed to .ico |
Yes, well, it was really a 32x32 png converted to ico with https://convertico.com/, but I tried with https://filehelper.com/ and in the file details it tells me: File Properties With any other png image the result would be: Name: I also tried with https://jumpshare.com/viewer/ico and if the image uploaded in ico it displays it, otherwise if it is a png we will get the error: Whoops! Not the Right Type of File So, according to me, the icon has been created correctly and is the one I attached in this request. Should I generate the ico file in another way that passes the test? Greetings, thank you. |
This is a png-encoded icon, which is invalid in this case. |
Ok @learn-more, I have extracted the installer icon using "IconsExtract" from NirSoft, but the only icon it extracts measures 128x128 pixels. It seems to me that 32x32 are needed here, right? |
That is a tad big indeed, but there are more icons like that, so as long as ReactOS can display it that would be fine with me. |
Reupload FileOptimizer icon, at 128x128px, but this time it is a valid .ico.
Ready, I have re-uploaded the ico file in 128x128, it was extracted directly from the FileOptimizer installer exe. |
Thanks for your contribution! |
Thanks!!!! |
Reupload file icon, the last is corrupted?