fix(scroll): #5995 keep computed height to avoid page jump #7146
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hi @ssan93! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Size changes📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
| Page | Size (compressed) |
|---|---|
global |
104.19 KB (🟡 +1 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Closes #5995
Issue
When the iframe gets out of range, it unmounts to save memory. While scrolling on desktop widths (vertical layout), the iframes are unmounting and their height gets reduced. This causes page jump as the previous content gets shorter.
Solution
By keeping the calculated height value of the iframe, we can set the height of the iframe wrapper to prevent shrinking and remove the page jumps.
Reactdev-page-jump.mp4