Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump sandboxes to use latest Canary #7116

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Aug 19, 2024

Test plan

  • list all changed demos and verify they still work

Copy link

vercel bot commented Aug 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
19-react-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 19, 2024 5:14pm
react-dev ✅ Ready (Inspect) Visit Preview Aug 19, 2024 5:14pm

Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Five Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 104.26 KB (🟢 -19 B) 208.45 KB
/500 104.25 KB (🟢 -19 B) 208.45 KB
/[[...markdownPath]] 106.1 KB (🟢 -19 B) 210.3 KB
/errors 104.47 KB (🟢 -19 B) 208.66 KB
/errors/[errorCode] 104.44 KB (🟢 -19 B) 208.64 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@@ -49,8 +49,8 @@ export default function formatHTML(markup) {
const packageJSON = `
{
"dependencies": {
"react": "18.3.0-canary-6db7f4209-20231021",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verifying for SandpackWithHTMLOutput instances:

  • /reference/react-dom/components/link#linking-to-related-resources
  • /reference/react-dom/components/link#linking-to-a-stylesheet
  • /reference/react-dom/components/link#controlling-stylesheet-precedence
  • /reference/react-dom/components/link#deduplicated-stylesheet-rendering
  • /reference/react-dom/components/meta#annotating-the-document-with-metadata
  • /reference/react-dom/components/script#rendering-an-external-script
  • /reference/react-dom/components/script#rendering-an-inline-script
-      <script>ga(&#x27;send&#x27;, &#x27;pageview&#x27;);</script>
+      <script>ga('send', 'pageview');</script>
  • /reference/react-dom/components/style
+ data-href="PieChart-[&quot;red&quot;,&quot;green&quot;,&quot;blue&quot;]">#:R2: .color-0: { color: "red"; },#:R2: .color-1: { color: "green"; },#:R2: .color-2: { color: "blue"; }
- data-href="PieChart-[&quot;red&quot;,&quot;green&quot;,&quot;blue&quot;]">#:R2: .color-0: { color: &quot;red&quot;; },#:R2: .color-1: { color: &quot;green&quot;; },#:R2: .color-2: { color: &quot;blue&quot;; }
  • /reference/react-dom/components/title#set-the-document-title ✅

@@ -133,8 +133,8 @@ export async function deliverMessage(message) {
```json package.json hidden
{
"dependencies": {
"react": "18.3.0-canary-6db7f4209-20231021",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants