Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: awkward sentences #1034

Merged
merged 11 commits into from
Aug 29, 2024
Merged

fix: awkward sentences #1034

merged 11 commits into from
Aug 29, 2024

Conversation

happyhyep
Copy link
Contributor

안녕하세요, 읽다가 어색한 문장을 발견하여 수정하였습니다 !
좋은 문서 감사합니다!!

Progress

@vercel Vercel
Copy link

vercel bot commented Aug 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
ko-legacy-reactjs-org ⬜️ Ignored (Inspect) Visit Preview Aug 29, 2024 3:06pm

@lumirlumir lumirlumir self-requested a review August 28, 2024 15:09
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 28, 2024 •
edited
Loading

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

lumirlumir
lumirlumir requested changes Aug 28, 2024
View reviewed changes
Copy link
Collaborator

@lumirlumir lumirlumir left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

안녕하세요😊 src/content/learn/keeping-components-pure.md 파일을 제외한 나머지 추가된 파일은 반영이 불가합니다.

실수로 다른 파일들이 같이 올라온 듯 한데, 수정 후 다시 커밋 부탁드리겠습니다.

.idea/.gitignore Outdated Show resolved Hide resolved
.idea/codeStyles/Project.xml Outdated Show resolved Hide resolved
.idea/codeStyles/codeStyleConfig.xml Outdated Show resolved Hide resolved
.idea/inspectionProfiles/Project_Default.xml Outdated Show resolved Hide resolved
.idea/ko.react.dev.iml Outdated Show resolved Hide resolved
.idea/misc.xml Outdated Show resolved Hide resolved
.idea/modules.xml Outdated Show resolved Hide resolved
.idea/vcs.xml Outdated Show resolved Hide resolved
@lumirlumir lumirlumir enabled auto-merge (squash) August 29, 2024 15:08
@lumirlumir lumirlumir self-requested a review August 29, 2024 15:09
@lumirlumir lumirlumir merged commit 56f1f91 into reactjs:main Aug 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lumirlumir lumirlumir lumirlumir approved these changes

@hg-pyun hg-pyun Awaiting requested review from hg-pyun hg-pyun is a code owner

@taehwanno taehwanno Awaiting requested review from taehwanno taehwanno is a code owner

@simsim0709 simsim0709 Awaiting requested review from simsim0709 simsim0709 is a code owner

@gnujoow gnujoow Awaiting requested review from gnujoow gnujoow is a code owner

@b9words b9words Awaiting requested review from b9words b9words is a code owner

@taggon taggon Awaiting requested review from taggon taggon is a code owner

@MaxKim-J MaxKim-J Awaiting requested review from MaxKim-J MaxKim-J is a code owner

@eomttt eomttt Awaiting requested review from eomttt eomttt is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@happyhyep @lumirlumir