Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translating forms.md #22

Closed
wants to merge 11 commits into from
Closed

Translating forms.md #22

wants to merge 11 commits into from

Conversation

SahibArora
Copy link

Hi there,
Sorry I started working on it, before your reply, just a little bit excited towards my first open source contribution. Hope you don't mind.
I am just opening a PR request for forms which I will be updating with time. When I will be done, I will let you know.

Thank you,

@netlify
Copy link

netlify bot commented Mar 6, 2019 •
edited
Loading

Deploy preview for hi-reactjs ready!

Built with commit f0cc6df

https://deploy-preview-22--hi-reactjs.netlify.com

@tesseralis tesseralis mentioned this pull request Mar 6, 2019
Closed
88 tasks
arshadkazmi42
arshadkazmi42 requested changes Mar 6, 2019
View reviewed changes
Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start.
I have left a few comments, let's fix all those feedback reviews first before continuing with further translations of page

Please read #23 before working on the review fixes

content/docs/forms.md Outdated Show resolved Hide resolved
content/docs/forms.md Outdated Show resolved Hide resolved
content/docs/forms.md Outdated Show resolved Hide resolved
content/docs/forms.md Outdated Show resolved Hide resolved
content/docs/forms.md Outdated Show resolved Hide resolved
content/docs/forms.md Outdated Show resolved Hide resolved
content/docs/forms.md Outdated Show resolved Hide resolved
content/docs/forms.md Outdated Show resolved Hide resolved
content/docs/forms.md Outdated Show resolved Hide resolved
content/docs/forms.md Outdated Show resolved Hide resolved
@SahibArora
Copy link
Author

SahibArora commented Mar 7, 2019 •
edited
Loading

Hi there,

Thanks for the suggestions.
I did the changes, you asked me.
Please give it a look and then I will continue further.

Thanks,

arshadkazmi42
arshadkazmi42 reviewed Mar 7, 2019
View reviewed changes
content/docs/forms.md Outdated Show resolved Hide resolved
content/docs/forms.md Outdated Show resolved Hide resolved
arshadkazmi42
arshadkazmi42 requested changes Mar 7, 2019
View reviewed changes
Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great progress.
Added some more comments and you have missed few of the previous suggestions

@SahibArora
Copy link
Author

I did the changes, thanks for your suggestions again.
I will carry on with the translating.
Thanks!

@arshadkazmi42
Copy link
Member

@SahibArora There is one line left for translation line 30, once you can do the translation of that line, I can review and approve it for second round of review.

@arshadkazmi42
Copy link
Member

@SahibArora Any updates on this? Let us know if you need any help from our end

@arshadkazmi42
Copy link
Member

@SahibArora Any updates on this? Let us know if you need any help from our end

@arshadkazmi42
Copy link
Member

@SahibArora Any updates?

@saranshkataria
Copy link
Member

@SahibArora please let us know if you will be working on this?

@SahibArora
Copy link
Author

Hi @arshadkazmi42,
I apologize for the delay and not been able to follow-up to your past messages.
I will go through it right away and submit the file as soon as possible.
Sorry again for the inconvenience caused because of me.

@saranshkataria
Copy link
Member

@SahibArora no worries. Just wanted to ensure that you will complete it. Let us know if you need any help

@saranshkataria
Copy link
Member

@SahibArora any updates?

@saranshkataria
Copy link
Member

Closing this PR due to inactivity. Feel free to reopen if you are going to work on it in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arshadkazmi42 arshadkazmi42 arshadkazmi42 requested changes

Assignees
No one assigned
Labels
awaiting author response
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SahibArora @arshadkazmi42 @saranshkataria