Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conditional rendering page translation #177

Merged

Conversation

sanchit36
Copy link
Contributor

Translating the conditional rendering page.
Related to #168
Review Progress

  • Conditionally including JSX
  • Conditional (ternary) operator (? :)
  • Logical AND operator (&&)
  • Conditionally assigning JSX to a variable
  • Show an icon for incomplete items with ? :
  • Show the item importance with &&
  • Refactor a series of ? : to if and variables

I have done till Conditionally assigning JSX to a variable.

Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work again.

Added review in the file.

Lets close these, then you can continue with further translations

beta/src/pages/learn/conditional-rendering.md Outdated Show resolved Hide resolved
beta/src/pages/learn/conditional-rendering.md Outdated Show resolved Hide resolved
beta/src/pages/learn/conditional-rendering.md Outdated Show resolved Hide resolved
beta/src/pages/learn/conditional-rendering.md Outdated Show resolved Hide resolved
beta/src/pages/learn/conditional-rendering.md Outdated Show resolved Hide resolved
beta/src/pages/learn/conditional-rendering.md Outdated Show resolved Hide resolved
beta/src/pages/learn/conditional-rendering.md Outdated Show resolved Hide resolved
beta/src/pages/learn/conditional-rendering.md Outdated Show resolved Hide resolved
beta/src/pages/learn/conditional-rendering.md Outdated Show resolved Hide resolved
beta/src/pages/learn/conditional-rendering.md Outdated Show resolved Hide resolved
@arshadkazmi42
Copy link
Member

@sanchit36 I have verified the fixes. All looks good. You can continue further with translating the rest of the file

@sanchit36
Copy link
Contributor Author

@arshadkazmi42 I have completed the page, need your review.

Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added review for rest of the changes.

Once these are fixed. these should be go to be merged

beta/src/pages/learn/conditional-rendering.md Outdated Show resolved Hide resolved
beta/src/pages/learn/conditional-rendering.md Outdated Show resolved Hide resolved
beta/src/pages/learn/conditional-rendering.md Outdated Show resolved Hide resolved
beta/src/pages/learn/conditional-rendering.md Outdated Show resolved Hide resolved
beta/src/pages/learn/conditional-rendering.md Outdated Show resolved Hide resolved
beta/src/pages/learn/conditional-rendering.md Outdated Show resolved Hide resolved
beta/src/pages/learn/conditional-rendering.md Outdated Show resolved Hide resolved
beta/src/pages/learn/conditional-rendering.md Outdated Show resolved Hide resolved
beta/src/pages/learn/conditional-rendering.md Outdated Show resolved Hide resolved
beta/src/pages/learn/conditional-rendering.md Outdated Show resolved Hide resolved
Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work.

Lets get this merged 👍

@arshadkazmi42 arshadkazmi42 merged commit 7a92068 into reactjs:main Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants