-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds introduction-jsx para of introducing-jsx page #12
Conversation
@arshadkazmi42 is there a reason you're doing these one section at a time? |
@tesseralis We were doing this to make translation and review process easier. As some pages are huge and its becoming a bit complex while reviewing. |
What I'd recommend, and what I've seen other languages do, is turn this into a "work in progress". You can work on one section at a time and update the PR as you go, asking people to review sections as you go by them. I think it's important to keep a page on a single PR -- if it's split up into multiple sections, the style can get inconsistent and it'll be harder to read and verify. This was the problem we had with Crowdin: people only translated sections of even single sentences of a page and the end result would be a mishmash of English and the translated language. |
It does makes sense. |
I like the WIP idea and reviewing it in parts! |
Yeah! And at the end you just need to skim it for consistency. |
Going back and forth is somewhat a challenge though. For example, #8 has 65 messages in the conversation tab and it is nowhere near done yet. |
Had a discussion with @arshadkazmi42 about the whole process. We will be having one PR for sections now onwards but to make the review process easier, we will go file by file and have a WIP PR as suggested by you @tesseralis. Thanks for the inputs. Will document it somewhere for other contributors soon. |
@arshadkazmi42 are we going to create a separate PR for this now? Or will you change the title for this and add subsequent changes section wise? |
I will be updating the same PR with subsequent section changes once current section is reviewed |
Deploy preview for hi-reactjs ready! Built with commit 08e4a9f |
Perfect! |
I will continue with next sections translation |
@arshadkazmi42 not reviewing the newer changes here, let's finish the other PR first 😄 |
``` | ||
|
||
This funny tag syntax is neither a string nor HTML. | ||
यह अजीब टैग सिंटैक्स न तो एक स्ट्रिंग है और न ही HTML है। |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove hai
at the end!
Closing due to inactivity |
Related to #1