Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Learn react #378

Closed
wants to merge 4 commits into from
Closed

Learn react #378

wants to merge 4 commits into from

Conversation

nasirmovlamov
Copy link
Collaborator

Translating home page main content.

@nasirmovlamov
Copy link
Collaborator Author

@GasimGasimzada

@azizaismayilova
Copy link
Collaborator

Hi @nasirmovlamov ! can you please add your name in translation progress list according which page you doing? So nobody will work on the same content :)

@nasirmovlamov
Copy link
Collaborator Author

nasirmovlamov commented Apr 26, 2023

Hi @azizaismayilova , sure

@nasirmovlamov
Copy link
Collaborator Author

@GasimGasimzada @azizaismayilova i updated content based on dictionary

@GasimGasimzada
Copy link
Collaborator

@nasirmovlamov According to React team, these pages -- homepage, header, and footer will go through invasive changes, which will result in significant amount of merge conflicts when the changes are synced with this repository. This will result in either spending a lot of time fixing the conflicts or rewriting this from the beginning again. In order to not duplicate this work, I would like you to close all your PRs with regards to UI changes and do translations of other translations (anything in "Main Content" section in #376).

We suggest to leave most of the UI translation until the end. We plan to do some invasive changes to the website folder layout and components, so postponing this until your translation is almost complete would make it easier to merge the changes from our side later. It might make sense to translate the homepage above the fold early, but leave the rest for later. As individual pages get translated, you can change the page titles in the corresponding sidebar files. Finally, when you're translating the navigation, make sure to test both desktop and mobile layouts.

@nasirmovlamov
Copy link
Collaborator Author

@GasimGasimzada for sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants