Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support interfaces with different name casing #1930

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

TimothyMakkison
Copy link
Contributor

@TimothyMakkison TimothyMakkison commented Nov 11, 2024

  • Add StringComparer.OrdinalIgnoreCase to keyCount
  • Added name casing test and same name, different signature test

Fixes #1689

@TimothyMakkison TimothyMakkison marked this pull request as ready for review November 11, 2024 19:29
@TimothyMakkison TimothyMakkison force-pushed the fix_interface_case branch 2 times, most recently from 16606ac to 907ecf3 Compare November 11, 2024 19:30
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.95%. Comparing base (6ebeda5) to head (b36cd1d).
Report is 168 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1930      +/-   ##
==========================================
- Coverage   87.73%   84.95%   -2.78%     
==========================================
  Files          33       36       +3     
  Lines        2348     2506     +158     
  Branches      294      364      +70     
==========================================
+ Hits         2060     2129      +69     
- Misses        208      299      +91     
+ Partials       80       78       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisPulman ChrisPulman merged commit f8bf4bb into reactiveui:main Nov 14, 2024
2 of 3 checks passed
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: source generation fails when interfaces mismatch in casing when inheriting generic interfaces.
2 participants