Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document InnerHandler null requirement for DI #1569

Merged
merged 2 commits into from
Oct 1, 2023

Conversation

bbrandt
Copy link
Contributor

@bbrandt bbrandt commented Sep 27, 2023

What kind of change does this PR introduce?
docs update

What is the current behavior?
See #1403

What is the new behavior?
Clearly documented

What might this PR break?
documentation only. Helps devs get started more easily with Auth in Refit.

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

@codecov
Copy link

codecov bot commented Oct 1, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (dc07cfb) 90.08% compared to head (93c530f) 90.08%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1569   +/-   ##
=======================================
  Coverage   90.08%   90.08%           
=======================================
  Files          33       33           
  Lines        1685     1685           
=======================================
  Hits         1518     1518           
  Misses        167      167           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glennawatson glennawatson merged commit b59977f into reactiveui:main Oct 1, 2023
3 checks passed
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 16, 2023
@bbrandt bbrandt deleted the patch-1 branch October 16, 2023 02:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants