fix: JsonPropertyName attribute is ignored for query params. #1544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glennawatson
reviewed
Oct 1, 2023
Refit.Tests/RequestBuilder.cs
Outdated
|
|
||
| [AliasAs("test-alias")] | ||
| [JsonPropertyName("test-json-property")] | ||
| public string TestAliAsWithJsonProperty { get; set; } |
There was a problem hiding this comment.
Is that a incorrect capital A in mistake with AliAs
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1544 +/- ##
==========================================
- Coverage 90.08% 90.07% -0.02%
==========================================
Files 33 33
Lines 1685 1683 -2
==========================================
- Hits 1518 1516 -2
Misses 167 167
☔ View full report in Codecov by Sentry. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
#1541
What is the current behavior?
What is the new behavior?
What might this PR break?
Please check if the PR fulfills these requirements
Other information: