Fixes issue #952 - we did not actually write everything to output str…

…eam.
reactiveui · Nov 26, 2020 · f01a96b · f01a96b
1 parent 670e2ea
commit f01a96b
Show file tree

Hide file tree

Showing 6 changed files with 39 additions and 5 deletions.
diff --git a/Refit.Tests/RefitStubs.Net46.cs b/Refit.Tests/RefitStubs.Net46.cs
@@ -2542,6 +2542,14 @@ Task IRequestBin.PostGeneric<T>(T param)
             var func = requestBuilder.BuildRestResultFuncForMethod("PostGeneric", new Type[] { typeof(T) }, new Type[] { typeof(T) });
             return (Task)func(Client, arguments);
         }
+
+        /// <inheritdoc />
+        Task IRequestBin.PostBig(BigObject big)
+        {
+            var arguments = new object[] { big };
+            var func = requestBuilder.BuildRestResultFuncForMethod("PostBig", new Type[] { typeof(BigObject) });
+            return (Task)func(Client, arguments);
+        }
     }
 }
 

diff --git a/Refit.Tests/RefitStubs.Net5.cs b/Refit.Tests/RefitStubs.Net5.cs
@@ -2542,6 +2542,14 @@ Task IRequestBin.PostGeneric<T>(T param)
             var func = requestBuilder.BuildRestResultFuncForMethod("PostGeneric", new Type[] { typeof(T) }, new Type[] { typeof(T) });
             return (Task)func(Client, arguments);
         }
+
+        /// <inheritdoc />
+        Task IRequestBin.PostBig(BigObject big)
+        {
+            var arguments = new object[] { big };
+            var func = requestBuilder.BuildRestResultFuncForMethod("PostBig", new Type[] { typeof(BigObject) });
+            return (Task)func(Client, arguments);
+        }
     }
 }
 

diff --git a/Refit.Tests/RefitStubs.NetCore2.cs b/Refit.Tests/RefitStubs.NetCore2.cs
@@ -2542,6 +2542,14 @@ Task IRequestBin.PostGeneric<T>(T param)
             var func = requestBuilder.BuildRestResultFuncForMethod("PostGeneric", new Type[] { typeof(T) }, new Type[] { typeof(T) });
             return (Task)func(Client, arguments);
         }
+
+        /// <inheritdoc />
+        Task IRequestBin.PostBig(BigObject big)
+        {
+            var arguments = new object[] { big };
+            var func = requestBuilder.BuildRestResultFuncForMethod("PostBig", new Type[] { typeof(BigObject) });
+            return (Task)func(Client, arguments);
+        }
     }
 }
 

diff --git a/Refit.Tests/RefitStubs.NetCore3.cs b/Refit.Tests/RefitStubs.NetCore3.cs
@@ -2542,6 +2542,14 @@ Task IRequestBin.PostGeneric<T>(T param)
             var func = requestBuilder.BuildRestResultFuncForMethod("PostGeneric", new Type[] { typeof(T) }, new Type[] { typeof(T) });
             return (Task)func(Client, arguments);
         }
+
+        /// <inheritdoc />
+        Task IRequestBin.PostBig(BigObject big)
+        {
+            var arguments = new object[] { big };
+            var func = requestBuilder.BuildRestResultFuncForMethod("PostBig", new Type[] { typeof(BigObject) });
+            return (Task)func(Client, arguments);
+        }
     }
 }
 

diff --git a/Refit/Buffers/PooledBufferWriter.Stream.NETStandard21.cs b/Refit/Buffers/PooledBufferWriter.Stream.NETStandard21.cs
@@ -14,18 +14,17 @@ internal sealed partial class PooledBufferWriter
         private sealed partial class PooledMemoryStream : Stream
         {
             /// <inheritdoc/>
-            public override void CopyTo(Stream destination, int bufferSize)
+            public Task CopyToInternalAsync(Stream destination, CancellationToken cancellationToken)
             {
                 if (pooledBuffer is null) ThrowObjectDisposedException();
 
                 var bytesAvailable = length - position;
-                var spanLength = Math.Min(bytesAvailable, bufferSize);
 
-                var source = pooledBuffer.AsSpan(position, spanLength);
+                var source = pooledBuffer.AsMemory(position, bytesAvailable);
 
                 position += source.Length;
 
-                destination.Write(source);
+                return destination.WriteAsync(source, cancellationToken).AsTask();
             }
 
             /// <inheritdoc/>

diff --git a/Refit/Buffers/PooledBufferWriter.Stream.cs b/Refit/Buffers/PooledBufferWriter.Stream.cs
@@ -91,9 +91,12 @@ public override Task CopyToAsync(Stream destination, int bufferSize, Cancellatio
 
                 try
                 {
+#if NETSTANDARD2_1 || NET5_0
+                    return CopyToInternalAsync(destination, cancellationToken);
+#else
                     CopyTo(destination, bufferSize);
-
                     return Task.CompletedTask;
+#endif
                 }
                 catch (OperationCanceledException e)
                 {