Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency roslynator.analyzers to 4.12.11 #973

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Directory.build.props
Original file line number Diff line number Diff line change
@@ -54,7 +54,7 @@
<ItemGroup>
<PackageReference Include="Nerdbank.GitVersioning" Version="3.7.115" PrivateAssets="all" />
<PackageReference Include="stylecop.analyzers" Version="1.2.0-beta.556" PrivateAssets="all" />
<PackageReference Include="Roslynator.Analyzers" Version="4.12.5" PrivateAssets="All" />
<PackageReference Include="Roslynator.Analyzers" Version="4.12.11" PrivateAssets="All" />
</ItemGroup>
<ItemGroup>
<AdditionalFiles Include="$(MSBuildThisFileDirectory)stylecop.json" Link="stylecop.json" />

Unchanged files with check annotations Beta

Assert.True(lockOne.IsCompleted);
Assert.Equal(TaskStatus.RanToCompletion, lockOne.Status);
Assert.NotNull(lockOne.Result);

Check warning on line 29 in src/Akavache.Tests/AsyncLockTests.cs

GitHub Actions / build / build

Test methods should not use blocking task operations, as they can cause deadlocks. Use an async test method and await instead. (https://xunit.net/xunit.analyzers/rules/xUnit1031)
Assert.False(lockTwo.IsCompleted);
Assert.True(lockTwo.IsCompleted);
Assert.True(lockTwo.IsCanceled);
lockOne.Result.Dispose();

Check warning on line 38 in src/Akavache.Tests/AsyncLockTests.cs

GitHub Actions / build / build

Test methods should not use blocking task operations, as they can cause deadlocks. Use an async test method and await instead. (https://xunit.net/xunit.analyzers/rules/xUnit1031)
}
}
Assert.Equal(0, output.Count);
outSub.OnNext(new[] { new CacheElement { Key = "Foo" } });
outSub.OnCompleted();
await Task.Delay(500).ConfigureAwait(false);

Check warning on line 45 in src/Akavache.Tests/CoalescerTests.cs

GitHub Actions / build / build

Test methods should not call ConfigureAwait(false), as it may bypass parallelization limits. Omit ConfigureAwait, or use ConfigureAwait(true) to avoid CA2007. (https://xunit.net/xunit.analyzers/rules/xUnit1030)
Assert.Equal(1, output.Count);
}
Assert.Equal(0, output.Count);
outSub.OnNext(new[] { new CacheElement { Key = "Foo" } });
outSub.OnCompleted();
await Task.Delay(500).ConfigureAwait(false);

Check warning on line 77 in src/Akavache.Tests/CoalescerTests.cs

GitHub Actions / build / build

Test methods should not call ConfigureAwait(false), as it may bypass parallelization limits. Omit ConfigureAwait, or use ConfigureAwait(true) to avoid CA2007. (https://xunit.net/xunit.analyzers/rules/xUnit1030)
Assert.Equal(1, output.Count);
}
Assert.Equal(0, output.Count);
outSub.OnNext(fakeResult);
outSub.OnCompleted();
await Task.Delay(1000).ConfigureAwait(false);

Check warning on line 123 in src/Akavache.Tests/CoalescerTests.cs

GitHub Actions / build / build

Test methods should not call ConfigureAwait(false), as it may bypass parallelization limits. Omit ConfigureAwait, or use ConfigureAwait(true) to avoid CA2007. (https://xunit.net/xunit.analyzers/rules/xUnit1030)
Assert.Equal(3, output.Count);
}
Assert.Equal(0, output.Count);
outSub.OnNext(fakeResult);
outSub.OnCompleted();
await Task.Delay(1000).ConfigureAwait(false);

Check warning on line 164 in src/Akavache.Tests/CoalescerTests.cs

GitHub Actions / build / build

Test methods should not call ConfigureAwait(false), as it may bypass parallelization limits. Omit ConfigureAwait, or use ConfigureAwait(true) to avoid CA2007. (https://xunit.net/xunit.analyzers/rules/xUnit1030)
Assert.Equal(4, output.Count);
}
var data = new byte[] { 0x10, 0x20, 0x30, };
var keys = new[] { "Foo", "Bar", "Baz", };
await Task.WhenAll(keys.Select(async v => await fixture.Insert(v, data).FirstAsync())).ConfigureAwait(false);

Check warning on line 26 in src/Akavache.Tests/TestBases/BulkOperationsTestBase.cs

GitHub Actions / build / build

Test methods should not call ConfigureAwait(false), as it may bypass parallelization limits. Omit ConfigureAwait, or use ConfigureAwait(true) to avoid CA2007. (https://xunit.net/xunit.analyzers/rules/xUnit1030)
Assert.Equal(keys.Length, (await fixture.GetAllKeys().FirstAsync()).Count());
var data = new byte[] { 0x10, 0x20, 0x30, };
var keys = new[] { "Foo", "Bar", "Baz", };
await Task.WhenAll(keys.Select(async v => await fixture.Insert(v, data, DateTimeOffset.MinValue).FirstAsync())).ConfigureAwait(false);

Check warning on line 50 in src/Akavache.Tests/TestBases/BulkOperationsTestBase.cs

GitHub Actions / build / build

Test methods should not call ConfigureAwait(false), as it may bypass parallelization limits. Omit ConfigureAwait, or use ConfigureAwait(true) to avoid CA2007. (https://xunit.net/xunit.analyzers/rules/xUnit1030)
var allData = await fixture.Get(keys).FirstAsync();
Assert.Equal(0, allData.Count);
var data = new byte[] { 0x10, 0x20, 0x30, };
var keys = new[] { "Foo", "Bar", "Baz", };
await Task.WhenAll(keys.Select(async v => await fixture.Insert(v, data).FirstAsync())).ConfigureAwait(false);

Check warning on line 95 in src/Akavache.Tests/TestBases/BulkOperationsTestBase.cs

GitHub Actions / build / build

Test methods should not call ConfigureAwait(false), as it may bypass parallelization limits. Omit ConfigureAwait, or use ConfigureAwait(true) to avoid CA2007. (https://xunit.net/xunit.analyzers/rules/xUnit1030)
Assert.Equal(keys.Length, (await fixture.GetAllKeys().FirstAsync()).Count());
fixture.InsertObjects(input.Zip(inputItems, (key, value) => new { Key = key, Value = value }).ToDictionary(x => x.Key, x => x.Value)).Wait();
var keyDates = await fixture.GetCreatedAt(input);
Assert.Equal(keyDates.Keys.OrderBy(x => x), input.OrderBy(x => x));

Check failure on line 713 in src/Akavache.Tests/TestBases/BlobCacheExtensionsTestBase.cs

GitHub Actions / build / build

Optimize LINQ method call (https://josefpihrt.github.io/docs/roslynator/analyzers/RCS1077)

Check failure on line 713 in src/Akavache.Tests/TestBases/BlobCacheExtensionsTestBase.cs

GitHub Actions / build / build

Optimize LINQ method call (https://josefpihrt.github.io/docs/roslynator/analyzers/RCS1077)

Check failure on line 713 in src/Akavache.Tests/TestBases/BlobCacheExtensionsTestBase.cs

GitHub Actions / build / build

Optimize LINQ method call (https://josefpihrt.github.io/docs/roslynator/analyzers/RCS1077)

Check failure on line 713 in src/Akavache.Tests/TestBases/BlobCacheExtensionsTestBase.cs

GitHub Actions / build / build

Optimize LINQ method call (https://josefpihrt.github.io/docs/roslynator/analyzers/RCS1077)
keyDates.Values.All(x => x > now).Should().BeTrue();
}
}