Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds commandline parsing #2

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Adds commandline parsing #2

wants to merge 6 commits into from

Conversation

ststefa
Copy link

@ststefa ststefa commented Jul 12, 2022

I came across your (forked) repo and found it very useful in building something around nftables and prometheus! In a first step I added commandline parsing so that

  • one is not forced to use env vars
  • env vars are documented inline so that they are self-explanatory (i.e. no README required to discover them, which is esp. important if using a compiled version)

I plan to add more stuff as time allows. This is just to see if you're interested in having such merged back to you. I don't like forks a lot because they tend to fragment good ideas and makes it difficult to focus.

ststefa added 6 commits July 12, 2022 12:40
* add gathering commented counter rules

* give the main code a proper name

* Add interrupt handling for clean shutdown

* removeed sudo, use capabilities instead

* add Dockerfile
* add gathering commented counter rules

* give the main code a proper name

* typo

* review doc

* nitpicking

* Add interrupt handling for clean shutdown

* removeed sudo, use capabilities instead

* add Dockerfile

* multiarch build experiments

* give the main code a proper name

* review doc

* Add interrupt handling for clean shutdown

* multiarch build experiments

* rename main script

* build+doc

* add ci
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant