-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Toolbutton lag in complex layouts #147
Open
Valer100
wants to merge
11
commits into
rdbende:main
Choose a base branch
from
Valer100:fix-toolbutton-lag
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@rdbende Can you check this PR? |
It would also be nice to add a comment for new contributors at the beginning of both |
… are auto-generated.
…Valley-ttk-theme into fix-toolbutton-lag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! This PR fixes an issue where hovering a ttk button with the Toolbutton style applied changes its state from hovered to normal with a delay after it is not hovered. This issue affects both light and dark themes.
Here's a screen recording when the issue happens:
Before.mp4
Here's a screen recording with the fix applied:
After.mp4
This problem was happening because the sprite used by the Toolbutton for its normal state had a different size (10x10) than the rest of the button states (20x20).
I tested this on Linux and it doesn't happen at all, but it happens on Windows.