Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Toolbutton lag in complex layouts #147

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

Valer100
Copy link
Contributor

@Valer100 Valer100 commented Aug 2, 2024

Hi! This PR fixes an issue where hovering a ttk button with the Toolbutton style applied changes its state from hovered to normal with a delay after it is not hovered. This issue affects both light and dark themes.

Here's a screen recording when the issue happens:

Before.mp4

Here's a screen recording with the fix applied:

After.mp4

This problem was happening because the sprite used by the Toolbutton for its normal state had a different size (10x10) than the rest of the button states (20x20).

I tested this on Linux and it doesn't happen at all, but it happens on Windows.

@Valer100
Copy link
Contributor Author

@rdbende Can you check this PR?

@Valer100
Copy link
Contributor Author

It would also be nice to add a comment for new contributors at the beginning of both sprites_light.tcl and sprites_dark.tcl that they are auto-generated by spritesheet_generator.js and shouldn't be edited by hand. Only now I found out that they are auto-generated after experimenting with it in another branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant