Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update notebooks to use FieldDataset, patchify #48

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

alvinzz
Copy link
Collaborator

@alvinzz alvinzz commented Jun 17, 2022

No description provided.

@alvinzz alvinzz requested review from belsten, 9q9q and cshewmake2 June 17, 2022 22:32
Copy link
Collaborator

@9q9q 9q9q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Alvin! just aesthetic nits about the vanilla tutorial notebook:

  1. for some reason the plots/figures all look undertrained, could you return them to original condition? everything should look the same as before if you run it without changing params.
  2. not sure why this is happening, but the tutorial Field images have different vranges than they should. i set it so the contrast is higher: https://github.com/rctn/sparsecoding/blob/main/tutorials/vanilla/src/utils.py#L64, but it doesn't look like that is being applied to notebook in this branch
  3. could you fix the warnings? if it's a jupyter version/package issue i can do it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants