Improves Warning messaging #11
Conversation
Improves on the original warning.warn message (for when an envfile wasn't found) by including the search path used for a given file.
| @@ -183,6 +199,8 @@ def read_envfile(path=None, **overrides): | |||
| with open(path, 'r') as f: | |||
| content = f.read() | |||
| except getattr(__builtins__, 'FileNotFoundError', IOError): | |||
| # Append the path we tried (and failed) to find to a tracking table | |||
| traversed_paths = Env.track_path(path) | |||
There was a problem hiding this comment.
Nit, but Env can be cls here.
There was a problem hiding this comment.
Where it's used inside a static method, so there's no cls binding param AFAIK.
|
Looks useful. Think an additional function for this is probably overkill, just adding a |
Instead of implementing the (missing path) logging on the class level, instead just track as a list in the read_envfile params.
|
Thanks for saying that it looks useful and for quickly responding to the PR (👍 ). I think the last commit is what you had in mind, but let me know if I misunderstood and I can modify it. |
|
It is worth noting that the change to only use a list in that fashion means that the |
|
@rconradharris are you still maintaining this repo? The last commit is 7 years ago. Thanks |
Improves on the original warning.warn message (for when an envfile wasn't found) by including the search path used for a given file.