-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: reduce DB calls in plan list API #782
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Pull Request Test Coverage Report for Build 11103185081Details
💛 - Coveralls |
anujk14
changed the title
[Draft] [Optimization] Reduce DB calls in Plan list API
feat: reduce DB calls in Plan list API
Sep 23, 2024
anujk14
changed the title
feat: reduce DB calls in Plan list API
feat: reduce DB calls in plan list API
Sep 23, 2024
kushsharma
reviewed
Sep 23, 2024
kushsharma
reviewed
Sep 23, 2024
kushsharma
reviewed
Sep 23, 2024
kushsharma
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ListWithProducts
in Plans repository, which fetches plans along with the products that belong to the planListWithProducts
, to reduce the number of DB calls that are made to fetch plans+products+features.