Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💄 Refined the paginator #135

Closed
wants to merge 2 commits into from
Closed

💄 Refined the paginator #135

wants to merge 2 commits into from

Conversation

ckersey2
Copy link
Contributor

@ckersey2 ckersey2 commented Jul 19, 2024

💄 Refined the paginator
Updated the pagination actions buttons
If we are on the first page of the data, the "Previous" button is not shown.
If we are on the last page of the data, the "Next" button is not shown.

@ckersey2 ckersey2 changed the title Main Hide Previous and Next buttons when they are not needed in the Paginator Jul 19, 2024
@ckersey2 ckersey2 changed the title Hide Previous and Next buttons when they are not needed in the Paginator 🚜Hide Previous and Next buttons when they are not needed in the Paginator Jul 19, 2024
@ckersey2 ckersey2 changed the title 🚜Hide Previous and Next buttons when they are not needed in the Paginator 🚜Hide previous and next buttons when they are not needed in the paginator Jul 19, 2024
Copy link
Contributor Author

@ckersey2 ckersey2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small tweek.

@ckersey2 ckersey2 changed the title 🚜Hide previous and next buttons when they are not needed in the paginator ✨ Add new feature for pagination Jul 20, 2024
If we are on the first page of the data, the "Previous" button is not shown.
If we are on the last page of the data, the "Next" button is not shown.

I've updated the following tests:
- easy-paginator.spec.ts
- paginator.spec.ts

All tests pass.
@ckersey2 ckersey2 marked this pull request as ready for review July 24, 2024 02:52
@ckersey2 ckersey2 changed the title ✨ Add new feature for pagination 💄 Refined the Paginator Jul 24, 2024
@ckersey2 ckersey2 changed the title 💄 Refined the Paginator 💄 Refined the paginator Jul 24, 2024
@ckersey2 ckersey2 closed this Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant