implement basic watermarking #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
R: @pabloem |
iasoon
commented
Jun 15, 2022
| 'wrong input watermark for %s. Expected %s, but got %s.' % ( | ||
| ray.get(runner_execution_context.watermark_manager.get_stage_node.remote( | ||
| bundle_context_manager.stage.name)), | ||
| stage_node.output_watermark() == timestamp.MAX_TIMESTAMP), ( |
There was a problem hiding this comment.
This was indeed supposed to be output_watermark instead of input_watermark, right?
|
TODO @pabloem - what is the produced watermark and why do stages differentiate |
iasoon
force-pushed
the
watermarks
branch
3 times, most recently
from
4f0f971
to
015df34
Compare
|
Ran into an issue when implementing this: Overwriting the payload here also changes the transform in the original pipeline definition. This new format is different from what the watermark manager __init__ expects. I fixed it for now by making sure that the watermark manager initializes before the RayBundleContextManager runs, How is this expected to work? Should we copy the transform before we overwrite the payload?
|
|
once we start parallelizing the execution of bundles, our watermarking will need to change (we need to wait for all parallel tasks of a given stage before advancing its watermark and executing the downstream stages). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-enabled the watermarking code so that the watermark assertions pass again