Remove obsolete _DatasetWrapper #59310
Open
+3
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly removes the obsolete _DatasetWrapper, which was a temporary workaround. The changes simplify the code in stream_split_iterator.py and its usage in test_data_resource_cleanup.py by passing the Dataset object directly. The refactoring is clean, improves maintainability, and I found no issues with the implementation.
ray-gardener
bot
added
train
Contributor
|
Hi @Priya-753 . Thanks for your contribution. Can you please fix DCO that is failing. https://github.com/ray-project/ray/pull/59310/checks?check_run_id=57557757496 |
gvspraveen
added
the
@external-author-action-required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #59300