Skip to content

[Core] Fix crash when receiving empty message batch in RaySyncer #59298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
g199209 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Core] Fix crash when receiving empty message batch in RaySyncer #59298

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/ray/ray_syncer/ray_syncer_bidi_reactor_base.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,17 @@ class RaySyncerBidiReactorBase : public RaySyncerBidiReactor, public T {
}

// Successful rpc completion callback.
RAY_CHECK(!msg_batch->messages().empty());
// Note: gRPC may call OnReadDone with ok=true even when the message batch
// is empty in certain edge cases (e.g., connection established but no data
// sent yet, or race conditions).
if (msg_batch->messages().empty()) {
RAY_LOG(DEBUG) << "Received empty message batch from node: "
<< NodeID::FromBinary(GetRemoteNodeID())
<< ", starting next read";
StartPull();
return;
}

if (on_rpc_completion_) {
on_rpc_completion_(NodeID::FromBinary(remote_node_id_));
}
Expand Down