[RLLib] Fix some RLlib release tests #59288
Open
+143
−130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kamil Kaczmarek <[email protected]>
kamil-kaczmarek
added
testing
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates several RLlib release tests to run on the ray-ml image and assigns them to the rllib team, which aligns with the goal of fixing and standardizing RLlib release tests. The changes are generally good, but I've found a couple of potential misconfigurations where tests are set up to use GPU resources but are assigned to CPU-only clusters. This could lead to test failures. Please see the detailed comments.
pseudo-rnd-thoughts
approved these changes
Dec 9, 2025
Member
pseudo-rnd-thoughts
left a comment
pseudo-rnd-thoughts
left a comment
There was a problem hiding this comment.
Looks good to me
Do we need torch/torchvision in the byod_rllib.sh, if we run on ray-ml image?
Possibly not, I just copied the pip installs from a container image I've been using
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Signed-off-by: Kamil Kaczmarek <[email protected]>
… kk/fix-rllib-release-tests
matthewdeng
approved these changes
Dec 9, 2025
Signed-off-by: Kamil Kaczmarek <[email protected]>
Signed-off-by: Kamil Kaczmarek <[email protected]>
Signed-off-by: Kamil Kaczmarek <[email protected]>
kamil-kaczmarek
changed the title
Signed-off-by: Kamil Kaczmarek <[email protected]>
… kk/fix-rllib-release-tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
long_running_impalaandlong_running_many_ppo: moved tests specification toRLlib testssection.tune_rllib_connect_testandlong_running_many_ppo.tune_rllib_connect_test:release/rllib_tests.RLlib testssection.stableflag from RLlib tests.