[core][stats-die/08] kill metric_defs #59282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the deprecated metric_defs.h and metric_defs.cc files, along with all their usages throughout the codebase. This is a good cleanup effort following the deprecation of the old STATS system. The changes are mostly mechanical, involving removal of include directives, updating build files, and adjusting comments and documentation. All changes appear to be correct and consistent with the goal of the PR. I have reviewed all the modifications and found no issues.
ray-gardener
bot
added
core
edoakes
approved these changes
Dec 9, 2025
can-anyscale
force-pushed
the
can-statdie06
branch
2 times, most recently
from
7b97c0d to
dbb13ed
Compare
Signed-off-by: Cuong Nguyen <[email protected]>
can-anyscale
force-pushed
the
can-statdie07
branch
from
654b752 to
af391e9
Compare
angelinalg
approved these changes
Dec 10, 2025
Co-authored-by: angelinalg <[email protected]> Signed-off-by: Cuong Nguyen <[email protected]>
Remove stats.h and all of their usage in the code base. This follows the deprecation of STATS (#59121 and others) Test: - CI Signed-off-by: Cuong Nguyen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
metric_defs.handmetric_defs.ccand all of their usage in the code base. This follows the deprecation of STATS (#59121 and others)Test: