-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dashboard): add CPU temperature #232
Conversation
@MichaIng, 2 things I don't really like with the current implementation.
|
Probably a config file setting for °C vs °F is best, since we don't expect multiple people accessing one dashboard instance (do we?), so no need to have it client dependant. Not sure about the colours, I think there are tools to generate a set of colour codes based on amount which are max different from each other. |
Hmm... After (partially) implementing it, I realize that it will need to send the Celsius temperature anyway, to use it for the message calculation. Really, the only place it would actually be used is in the graph, so I think that a setting in the frontend actually makes more sense, as to not repeat code. |
This reverts commit d06db0f.
Actually, even better would probably be to send it as a global setting, so that it can't be changed on-the-fly and mess up the graph, and would still be client-independent. |
This reverts commit feef715.
@MichaIng, should work (with the setting) now, please review. |
Works well. Few things I recognised while playing around with the graphs, but not directly related to this PR:
But as said, those are basically own enhancements to the stats page. Shall I open a new issue with those, to be picked up once someone finds time? |
Many scripts use the units inconsistently, either MB or just M while showing MiB.
Indeed, at least it would need to be made more distinguishable by using colours. In theory the units could be adjusted depending on highest value, so that having only network graphs selected, e.g. KiB/KB is used and hence network activity better visible. But yeah, it's nothing urgent IMO, just something to keep in mind when having time and touching those graphs code anyway. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works very well, great job 👍. Also in dark mode, the colours are good visible.
No description provided.