Added cookie restrictions #408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumped PHP minimum version to 7.3.0 This was required to have the new function signature available, which allows setting the samesite attribute natively PHP 7.3.0 was introduced in 2018 - 7 years ago - it is already out of support since 2021 - 4 years ago. Updating to a more recent PHP version is recommended. Bumped recommended PHP and MySQL version to latest available version This update is aimed to resolve a security vulnerability reported by @marksocrates1111
|
Hi @Lemongrass3110 and the rAthena team, Thank you for the quick response and for deploying the fix. Setting the session cookie attribute 'samesite' => 'Strict' correctly mitigates the CSRF vulnerability I reported. This will prevent the browser from sending the cookie on cross-domain requests and block the attack. I appreciate you taking the report seriously and patching it so quickly. As a final step, has a CVE ID been requested for this vulnerability? Thank you and have a great day ahead! Mark |
Danil0v3s
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumped PHP minimum version to 7.3.0
This was required to have the new function signature available, which allows setting the samesite attribute natively PHP 7.3.0 was introduced in 2018 - 7 years ago - it is already out of support since 2021 - 4 years ago. Updating to a more recent PHP version is recommended.
Bumped recommended PHP and MySQL version to latest available version
This update is aimed to resolve a security vulnerability reported by @marksocrates1111