Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to wasm-pack and other WASM build refactoring #110

Merged
merged 2 commits into from
Jan 3, 2019

Conversation

ishitatsuyuki
Copy link
Contributor

@ishitatsuyuki ishitatsuyuki commented Dec 24, 2018

Merry Christmas!

Some technical debts:

  • A target symlink is included until support of workspace is implemented.
  • The Material design related libraries and icons are not actively getting developed. We probably want to move to our own CSS design at some point.

@ishitatsuyuki
Copy link
Contributor Author

TODO: get wasm-pack into the CI environment.

@cmtt
Copy link
Member

cmtt commented Dec 30, 2018

Hello @ishitatsuyuki, this is great work. We should address UI-related issues separately, e.g. after successful merge in a separate PR.

There are some issues:

  • the build is broken as clippy is currently missing for the most recent Rust version, issue CI build broken due to missing Clippy component  #111 has been created therefore for the record.
  • Please remove all files specific to the yarn package manager from the repository, as NPM is used by default and on CI.
  • Commit a package-lock.json.
  • Move index.html to src. The raw HTML could also be replaced with a template in this PR or in a separate one. Parcel provides support for the pug template language.
  • A (minimal) playground/README.md should be created, describing its purpose as well as the commands required to start the development server / the build.
  • @maciejhirsz, we should consider using GH pages for deployment as suggested in Deploy ratel-wasm using CI, MIME type #77.

A `target` symlink is included until support of workspace is implemented.
@ishitatsuyuki
Copy link
Contributor Author

I'm planning to add GitHub pages deployment sometime soon. To proceed, I need someone with privileges to do the following:

  • Decide which repository we would publish the pages and setup (configure) GitHub pages. It could be a branch of this repository, or a new organization-wide repository.

  • Obtain a token with push access. This could be:

    • Personal access token with your account
    • Personal access token with a new bot account
    • A token for a new private GitHub app (not tested)

    Then, add this token privately to Travis CI's environment as GH_TOKEN.

@cmtt
Copy link
Member

cmtt commented Dec 31, 2018

Thank you for the update. This is a good starting point for some UI updates after this PR has been merged.
@maciejhirsz, I'd propose to deploy the wasm build in a gh-pages branch until there is a website to integrate it into. Can you take it from here?

@ishitatsuyuki
Copy link
Contributor Author

@cmtt Is there anything left to review, or you're just waiting for @maciejhirsz's approval?

Copy link
Member

@maciejhirsz maciejhirsz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just waiting for me, I took a break from coding during the holidays :).

@maciejhirsz maciejhirsz merged commit ba8499c into ratel-rust:master Jan 3, 2019
@ishitatsuyuki ishitatsuyuki deleted the wasm-pack branch January 3, 2019 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants