Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pin ratatui to less than 0.27.0 #46

Merged
merged 1 commit into from
Jul 11, 2024
Merged

fix: pin ratatui to less than 0.27.0 #46

merged 1 commit into from
Jul 11, 2024

Conversation

robertpsoane
Copy link
Contributor

  • ratatui 0.27.0 introduces a number of breaking changes
  • while libraries are updating to v0.27 having an open upper bound is awkward as consumer crates can require both, causing compilation failures where the lock file isn't being followed
  • proposal that we pin a patch to <0.27.0 for compatibility, then relax dependency as part of upgrade to 0.27

@robertpsoane
fix: pin ratatui to less than 0.27.0
08a9e5b 
- ratatui 0.27.0 introduces a number of breaking changes
- while libraries are updating to v0.27 having an open upper bound is awkward as consumer crates can require both, causing compilation failures where the lock file isn't being followed
- proposal that we pin a patch to <0.27.0 for compatibility, then relax dependency as part of upgrade to 0.27
@robertpsoane robertpsoane mentioned this pull request Jun 24, 2024
Closed
@uttarayan21 uttarayan21 merged commit b74d05f into ratatui:master Jul 11, 2024
1 of 2 checks passed
@uttarayan21
Copy link
Collaborator

Thank you for the pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robertpsoane @uttarayan21