Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update IR filter removal #3939

Merged
merged 4 commits into from
Nov 27, 2024
Merged

Conversation

nllho
Copy link

@nllho nllho commented Nov 25, 2024

Resolves #2860.

Minor changes for readability and correctness:

  • Make the top-level section "IR filters" and move the introduction there.
  • Make "Filter Removal" a sub-section, and move the warnings there.
  • Note that the sample procedure applies to both HQ & GS cameras but specifically depicts/references the HQ camera (to address Update the filter removal section for the GS camera #2860).
  • Make the text match up to the images better!

@nllho nllho changed the title Update camera filter removal Update IR filter removal Nov 25, 2024
@nllho nllho requested a review from nathan-contino November 25, 2024 21:29
Copy link
Collaborator

@nathan-contino nathan-contino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions, but this is already a big step in the right direction. Hopefully you agree with my thoughts. If not, we'll hash it out. Thanks for improving this so far, almost there!

documentation/asciidoc/accessories/camera/filters.adoc Outdated Show resolved Hide resolved
documentation/asciidoc/accessories/camera/filters.adoc Outdated Show resolved Hide resolved
documentation/asciidoc/accessories/camera/filters.adoc Outdated Show resolved Hide resolved
documentation/asciidoc/accessories/camera/filters.adoc Outdated Show resolved Hide resolved
@nllho nllho requested a review from nathan-contino November 26, 2024 21:18
Copy link
Collaborator

@nathan-contino nathan-contino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm mod a style guide issue and a reword suggestion for a piece of prose you didn't write (but that walks all over our style guide nonetheless).

Fix those and I'll merge this bad boi right in!

documentation/asciidoc/accessories/camera/filters.adoc Outdated Show resolved Hide resolved
documentation/asciidoc/accessories/camera/filters.adoc Outdated Show resolved Hide resolved
@lurch
Copy link
Contributor

lurch commented Nov 27, 2024

#2860 says "There is a back cover is present on GS Cam" and "GS Cam does not have washers" so the assembly / disassembly instructions here might need some additional caveats to better cover both cameras?
( @nathan-contino Can we get a HQ and GS camera shipped to @nllho so that she isn't just "typing blind"? )

@nllho
Copy link
Author

nllho commented Nov 27, 2024

#2860 says "There is a back cover is present on GS Cam" and "GS Cam does not have washers" so the assembly / disassembly instructions here might need some additional caveats to better cover both cameras? ( @nathan-contino Can we get a HQ and GS camera shipped to @nllho so that she isn't just "typing blind"? )

That would be awesome 😁 This update is only intended to remove ambiguity about the example procedure (i.e. it is HQ Cam that is shown in the demonstration, not GQ Cam).

@nllho nllho requested a review from nathan-contino November 27, 2024 15:32
Copy link
Collaborator

@nathan-contino nathan-contino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! nice job 🚀

@nathan-contino nathan-contino merged commit fbc11e2 into develop Nov 27, 2024
1 check passed
@nathan-contino nathan-contino deleted the update-camera-filter-removal branch November 27, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the filter removal section for the GS camera
3 participants