-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update IR filter removal #3939
Update IR filter removal #3939
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions, but this is already a big step in the right direction. Hopefully you agree with my thoughts. If not, we'll hash it out. Thanks for improving this so far, almost there!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm mod a style guide issue and a reword suggestion for a piece of prose you didn't write (but that walks all over our style guide nonetheless).
Fix those and I'll merge this bad boi right in!
#2860 says "There is a back cover is present on GS Cam" and "GS Cam does not have washers" so the assembly / disassembly instructions here might need some additional caveats to better cover both cameras? |
That would be awesome 😁 This update is only intended to remove ambiguity about the example procedure (i.e. it is HQ Cam that is shown in the demonstration, not GQ Cam). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! nice job 🚀
Resolves #2860.
Minor changes for readability and correctness: