[WIP] refactor haproxy role #111
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nick M <[email protected]>
Signed-off-by: Nick M <[email protected]>
xunholy
reviewed
Mar 4, 2021
| @@ -1,21 +1,21 @@ | |||
| --- | |||
| - name: 'haproxy | ensure kubernetes manifests directory "{{ cluster_kubernetes_manifests_path }}" exists' | |||
| - name: 'manifests | ensure kubernetes manifests directory "{{ cluster_kubernetes_manifests_path }}" exists' | |||
| ansible.builtin.file: | |||
| path: '{{ cluster_kubernetes_manifests_path }}' | |||
There was a problem hiding this comment.
cluster_kubernetes_manifests_path isn't being initialized in defaults or the group vars
xunholy
reviewed
Mar 4, 2021
| {% endif -%} | ||
|
|
||
| frontend apiserver | ||
| bind {{ cluster_apiserver_frontend_ip }}:{{ cluster_apiserver_frontend_port }} |
There was a problem hiding this comment.
cluster_apiserver_frontend_ip & cluster_apiserver_frontend_port isn't being initialized in defaults or the group vars
xunholy
reviewed
Mar 4, 2021
| option httpchk GET /healthz | ||
| http-check expect status 200 | ||
| {% for host in groups['controlplane'] -%} | ||
| server {{ hostvars[host]['ansible_hostname'] }} {{ hostvars[host]['ansible_default_ipv4'].address }}:{{ cluster_apiserver_port }} check check-ssl verify none |
There was a problem hiding this comment.
cluster_apiserver_port is a new var to replace cluster_apiserver_bind_port?
|
Could you also add uninstall to the nuke playbook? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nick M [email protected]
Description
Refactor of the HAProxy role.
Objectives