Skip to content

Conversation

@misiugodfrey
Copy link
Contributor

Created a docker-compose.common.yml to factor out some of the duplicate code in the presto docker-compose files.

Copy link
Contributor

@simoneves simoneves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in isolation. What other current PRs is this compatible with?

@misiugodfrey
Copy link
Contributor Author

What other current PRs is this compatible with?

I don't think this should conflict with many other PRs. Most changes in this area right now are wrapping the docker-compose files, so they aren't touched that often.

Other than that, this change should have no semantic differences to what is already in place.

Copy link
Contributor

@mattgara mattgara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'd feel more confident this doesn't cause issues once we have regular builds working in GitHub that could validate this doesn't break anything.

@misiugodfrey
Copy link
Contributor Author

LGTM, I'd feel more confident this doesn't cause issues once we have regular builds working in GitHub that could validate this doesn't break anything.

Agreed! I don't mind holding off on this until the Github Actions PRs are through so that we can start proper testing.

Copy link
Contributor

@paul-aiyedun paul-aiyedun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@misiugodfrey misiugodfrey force-pushed the misiug/common-docker-files branch from 1ad2b63 to 9f145b1 Compare September 2, 2025 18:17
@misiugodfrey misiugodfrey merged commit 8785ab2 into main Sep 2, 2025
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants