Skip to content

Setup examples #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
narangvivek10 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Setup examples #72

narangvivek10 wants to merge 3 commits into from

Conversation

@narangvivek10
Copy link
Collaborator

@narangvivek10 narangvivek10 commented Dec 18, 2025

Fixes #67

@copy-pr-bot
Copy link

copy-pr-bot bot commented Dec 18, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@narangvivek10 narangvivek10 self-assigned this Dec 18, 2025
@narangvivek10 narangvivek10 added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Dec 18, 2025
@narangvivek10
Copy link
Collaborator Author

narangvivek10 commented Dec 18, 2025

/ok to test 44d9817

cjnolet
cjnolet reviewed Dec 23, 2025
View reviewed changes
examples/src/main/java/com/nvidia/cuvs/lucene/examples/AcceleratedHnswExample.java
@@ -0,0 +1,130 @@
/*
* SPDX-FileCopyrightText: Copyright (c) 2025, NVIDIA CORPORATION.
* SPDX-License-Identifier: Apache-2.0
Copy link
Member

@cjnolet cjnolet Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of "demo", which would be unique to this codebase, can we please use examples? That would mean a top-level dirrectory for examples/ And call the file AcceleratedHnswExample. This just helps with user navigation when we keep these things consistent across codebases. Someone familiar w/ cuvs can come to cuvs-java and have a familiar experience.

Copy link
Collaborator Author

@narangvivek10 narangvivek10 Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@narangvivek10 narangvivek10 marked this pull request as ready for review December 23, 2025 18:20
@narangvivek10 narangvivek10 requested review from a team as code owners December 23, 2025 18:20
jameslamb
jameslamb approved these changes Dec 23, 2025
View reviewed changes
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Giving this a ci-codeowners / packaging-codeowners approval so you can keep moving forward. The changes in build / CI scripts look non-controversial to me.

Agree with Corey's suggestion to call the top-level directory examples/ instead of demo/.

@jameslamb jameslamb removed the request for review from AyodeAwe December 23, 2025 18:50
@narangvivek10
Copy link
Collaborator Author

narangvivek10 commented Dec 23, 2025

Thank you, @jameslamb, for taking a look at the open PRs, especially during the holidays. Merry Christmas !!! 🎄 🎄 🎄

@narangvivek10
Copy link
Collaborator Author

narangvivek10 commented Dec 23, 2025

/ok to test 0d88a02

@narangvivek10 narangvivek10 changed the title Setup demos Setup examples Dec 23, 2025
@narangvivek10 narangvivek10 mentioned this pull request Dec 24, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjnolet cjnolet cjnolet left review comments

@jameslamb jameslamb jameslamb approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

@narangvivek10 narangvivek10

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Setup demo/examples

3 participants

@narangvivek10 @cjnolet @jameslamb