Skip to content

Conversation

@jameslamb
Copy link
Member

Proposing some small maintenance updates, things I noticed today while trying to get more familiar with this project.

  • removes libcuvs build dependencies like CMake, Ninja, and a bunch of CUDA toolkit libraries (we're not building libcuvs here, and the libcuvs conda package will pull in the runtime packages it needs)
  • minor stylistic changes to dependencies.yaml (clarifying naming, standardizing spelling of lists)

@jameslamb jameslamb added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Dec 2, 2025
@copy-pr-bot
Copy link

copy-pr-bot bot commented Dec 2, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@jameslamb
Copy link
Member Author

/ok to test

@narangvivek10
Copy link
Collaborator

narangvivek10 commented Dec 2, 2025

Hey @jameslamb, just so that you know, we currently need libcuvs, cmake, and ninja for building cuvs-java (please see #43 for context). We use cuvs-java as a dependency for cuvs-lucene. Once cuvs-java nightly snapshots are set up, I will simplify the build process, and then these won't be needed anymore. Please let me know if any questions. Thanks!

@jameslamb
Copy link
Member Author

Ah thanks, sorry I'd missed that the build here works by cloning the cuvs repo:

cuvs-lucene/build.sh

Lines 29 to 32 in 3efd0ff

git clone --branch "$BRANCH" $CUVS_GIT_REPO $CUVS_WORKDIR
pushd $CUVS_WORKDIR
fi
./build.sh java

I'll change the direction of this PR with a different suggestion... I think it should be possible to list the build dependencies of cuvs-java programmatically, without needing to hard-code them again here. That should reduce the risk of drift and make it easier for this repo to stay in sync with changes to cuVS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants