Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add catboost to the third-party integration tests #17267

Open
wants to merge 6 commits into
base: branch-24.12
Choose a base branch
from

Conversation

Matt711
Copy link
Contributor

@Matt711 Matt711 commented Nov 7, 2024

Description

Closes #15397

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@github-actions github-actions bot added Python Affects Python cuDF API. cudf.pandas Issues specific to cudf.pandas labels Nov 7, 2024
@Matt711 Matt711 added feature request New feature or request non-breaking Non-breaking change Python Affects Python cuDF API. cudf.pandas Issues specific to cudf.pandas and removed Python Affects Python cuDF API. cudf.pandas Issues specific to cudf.pandas labels Nov 7, 2024
@@ -37,6 +37,7 @@ jobs:
- unit-tests-cudf-pandas
- pandas-tests
- pandas-tests-diff
- third-party-integration-tests-cudf-pandas
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore the CI changes. I added them to show the third-party integration tests were passing. I'll delete them once this PR is approved.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the ping

@Matt711 Matt711 marked this pull request as ready for review November 8, 2024 21:25
@Matt711 Matt711 requested review from a team as code owners November 8, 2024 21:25
- scikit-learn
- pip
- pip:
- catboost
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to install this via pip? Appears catboost is on conda forge https://catboost.ai/en/docs/installation/python-installation-method-conda-install

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use conda if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cudf.pandas Issues specific to cudf.pandas feature request New feature or request non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
Status: In Progress
Status: In Progress
Development

Successfully merging this pull request may close these issues.

[FEA] Improve support or failure modes for numpy and other libraries with C APIs in cudf.pandas
4 participants